[kea-dev] kea apache cassandra/datastax cassandra

Tomek Mrugalski tomasz at isc.org
Thu May 19 11:06:09 UTC 2016


On 19.05.2016 10:58, Razvan Becheriu wrote:
> I work for Qualitance in collaboration with Deutsche Telekom.
> I have been working on improving the KEA server by adding support for
> apache cassandra/datastax cassandra.
I've been hearing about this Cassandra work for a while. It's exciting
to finally see the code.
> From my understanding, the new source files will be commited with
> "Apache License".
Yes. Please make sure you put the appropriate license note at the top of
each new file you added. I presume most of the new code comes in new
files. Also, make sure you update COPYING file. Adding a new section
there explaining that the Cassandra backend is distributed under Apache
license should do the trick. Another file to modify is AUTHORS. ISC
tries to keep track of all contributions that we received, but we're
flexible with it. We can put that whatever the contributor wants to -
name and company, just the name, only company, even anonymous is ok.

>
> I am ready to commit the changes to a separate branch (for code
> review). The source files have been updated to latest (main branch)
> version.
Great! Can you submit a pull request on github? I'm sure you know how to
do it, but in case you haven't used it before, here's
https://help.github.com/articles/using-pull-requests/. This seems to be
the best way forward, as we would be able to tweak the code during the
review.

Once I get the pull request, I'll start reviewing it.

I was told that this change also has some documentation. It would be
great if you could include it. I must admit I have never set up
Cassandra before, but I presume there will be some installation required
and then some form of database initalization, similar to SQL schema.
Will this be a part of the patch? If not, can you explain how to set up
a test environment?

> One thing to mention is that not all unit tests have been written for
> the cassandra backend.
That's unfortunate, but we can live with it. We always try to ask for
unit tests, but I still haven't seen a patch with full unit tests suite
:) Luckily the unit tests framework for the lease manager are structured
in a way that it's easy to extend to additional backends.
Once I see the code and understand it a bit, I'll write missing tests
for it.

Thanks a lot,
Tomek




More information about the kea-dev mailing list