[kea-dev] kea apache cassandra/datastax cassandra
Razvan Becheriu
razvan.becheriu at qualitance.com
Tue May 24 12:39:14 UTC 2016
Hi,
Have you been able to look over the pull request? Do you have access to the
files/changes?
I just want to make sure I did all the steps necessary for the pull-request.
Thanks,
Razvan
On Thu, May 19, 2016 at 5:42 PM, Razvan Becheriu <
razvan.becheriu at qualitance.com> wrote:
> Hi,
>
> I've updated the kea-admin script with the commands needed to initialize
> the database and added necessary scripts to call the cqlsh (cassandra
> database client).
>
> I've attached to this file the necessary documentation needed to build the
> datastax cpp driver and to build KEA with cassandra backend.
>
>
>
> On Thu, May 19, 2016 at 2:06 PM, Tomek Mrugalski <tomasz at isc.org> wrote:
>
>> On 19.05.2016 10:58, Razvan Becheriu wrote:
>> > I work for Qualitance in collaboration with Deutsche Telekom.
>> > I have been working on improving the KEA server by adding support for
>> > apache cassandra/datastax cassandra.
>> I've been hearing about this Cassandra work for a while. It's exciting
>> to finally see the code.
>> > From my understanding, the new source files will be commited with
>> > "Apache License".
>> Yes. Please make sure you put the appropriate license note at the top of
>> each new file you added. I presume most of the new code comes in new
>> files. Also, make sure you update COPYING file. Adding a new section
>> there explaining that the Cassandra backend is distributed under Apache
>> license should do the trick. Another file to modify is AUTHORS. ISC
>> tries to keep track of all contributions that we received, but we're
>> flexible with it. We can put that whatever the contributor wants to -
>> name and company, just the name, only company, even anonymous is ok.
>>
>> >
>> > I am ready to commit the changes to a separate branch (for code
>> > review). The source files have been updated to latest (main branch)
>> > version.
>> Great! Can you submit a pull request on github? I'm sure you know how to
>> do it, but in case you haven't used it before, here's
>> https://help.github.com/articles/using-pull-requests/. This seems to be
>> the best way forward, as we would be able to tweak the code during the
>> review.
>>
>> Once I get the pull request, I'll start reviewing it.
>>
>> I was told that this change also has some documentation. It would be
>> great if you could include it. I must admit I have never set up
>> Cassandra before, but I presume there will be some installation required
>> and then some form of database initalization, similar to SQL schema.
>> Will this be a part of the patch? If not, can you explain how to set up
>> a test environment?
>>
>> > One thing to mention is that not all unit tests have been written for
>> > the cassandra backend.
>> That's unfortunate, but we can live with it. We always try to ask for
>> unit tests, but I still haven't seen a patch with full unit tests suite
>> :) Luckily the unit tests framework for the lease manager are structured
>> in a way that it's easy to extend to additional backends.
>> Once I see the code and understand it a bit, I'll write missing tests
>> for it.
>>
>> Thanks a lot,
>> Tomek
>>
>>
>> _______________________________________________
>> kea-dev mailing list
>> kea-dev at lists.isc.org
>> https://lists.isc.org/mailman/listinfo/kea-dev
>>
>
>
>
> --
> *Razvan Becheriu* | senior software engineer | QUALITANCE™
> *RO:* +00 (000) 000 000 | *office:* +40 (372) 944 741
> Opera Center bldg. 2, fl. 7-8, 2 Dr. Nicolae D. Staicovici, Bucharest
> 050556
> <https://www.google.ro/maps/place/QUALITANCE/@44.433653,26.079464,17z/data=!4m6!1m3!3m2!1s0x40b1ff173c5bc0b9:0x7226343f810c7ede!2sQUALITANCE!3m1!1s0x40b1ff173c5bc0b9:0x7226343f810c7ede?hl=ro>
> razvan.becheriu at qualitance.com | www.qualitance.com
> --
> The information contained in this email is confidential. It is intended
> only for the stated addressee and access to it by any other person is
> unauthorised. If you are not an addressee, you must not disclose, copy,
> circulate or in another way use or reply to the information contained in
> this email. Such unauthorised use may be unlawful. If you have received
> this email in error, please notify the sender immediately and delete all
> copies from your computer and network.
>
--
*Razvan Becheriu* | senior software engineer | QUALITANCE™
*RO:* +00 (000) 000 000 | *office:* +40 (372) 944 741
Opera Center bldg. 2, fl. 7-8, 2 Dr. Nicolae D. Staicovici, Bucharest 050556
<https://www.google.ro/maps/place/QUALITANCE/@44.433653,26.079464,17z/data=!4m6!1m3!3m2!1s0x40b1ff173c5bc0b9:0x7226343f810c7ede!2sQUALITANCE!3m1!1s0x40b1ff173c5bc0b9:0x7226343f810c7ede?hl=ro>
razvan.becheriu at qualitance.com | www.qualitance.com
--
The information contained in this email is confidential. It is intended
only for the stated addressee and access to it by any other person is
unauthorised. If you are not an addressee, you must not disclose, copy,
circulate or in another way use or reply to the information contained in
this email. Such unauthorised use may be unlawful. If you have received
this email in error, please notify the sender immediately and delete all
copies from your computer and network.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.isc.org/pipermail/kea-dev/attachments/20160524/ba64099b/attachment.html>
More information about the kea-dev
mailing list