ds-lite comments

[Dave Taht]

While poking through whatever needed to patch into the kernel, if
anything, I had a chance to review the ds-lite patches in the openwrt
repository referenced.

I can see why this code was never considered for kernel inclusion. But
it does raise questions about the overall role of ds-lite in
everything, so while I'm here...


0) The 6rd patches were added in a useful way to the kernel mainline
after this came out.

ds-lite...

1)       if( skb->isthissoftwire[0] == 'a' && skb->isthissoftwire[1]
== 'b' && skb->isthissoftwire[2] == 'c')
is in the stack's *hotpath*.

And... adding fields to the skb struct requires special dispensation
from god himself.

My question actually was what was the 'softwire' concept? 'abc'? huh?

2) It used the /proc filesystem which has a format that has been
frozen and deprecated for nearly a decade

3) Stylistically

EXPORT_SYMBOL(SetSoftWireGlobalMTUinIPV6Output);

violates KernelStyle in several ways.

I'm still rooting through here to see what other patches are worthwhile...

-- 
Dave Täht
SKYPE: davetaht
US Tel: 1-239-829-5608
http://www.bufferbloat.net