Problem + Fix with recent news.daily

Heath Kehoe hakehoe at norand.com
Fri Dec 3 20:33:49 UTC 1999


There are some problems with some if[] tests in the news.daily
in the recent 2.3 snapshot.  Here's a fix.  Don't forget that
your lowercase conversions also turns the 'X' into 'x'.

--Heath


*** news.daily.in.dist	Fri Nov 26 10:57:25 1999
--- news.daily.in	Fri Dec  3 14:21:48 1999
***************
*** 64,70 ****
      fi
  fi
  ENABLEOVERVIEW=`echo X${ENABLEOVERVIEW} | tr ${AZ} ${az}`
! if [ ${ENABLEOVERVIEW} = X"true" -o X${ENABLEOVERVIEW} = X"yes" -o X${ENABLEOVERVIEW} = X"on" ]; then
      DOEXPIREOVER=true
      RMFILE=${MOST_LOGS}/expire.rm
  fi
--- 64,70 ----
      fi
  fi
  ENABLEOVERVIEW=`echo X${ENABLEOVERVIEW} | tr ${AZ} ${az}`
! if [ ${ENABLEOVERVIEW} = x"true" -o ${ENABLEOVERVIEW} = x"yes" -o ${ENABLEOVERVIEW} = x"on" ]; then
      DOEXPIREOVER=true
      RMFILE=${MOST_LOGS}/expire.rm
  fi
***************
*** 78,84 ****
  DOGROUPBASEEXPIRY=false
  
  GROUPBASEEXPIRY=`echo X${GROUPBASEEXPIRY} | tr ${AZ} ${az}`
! if [ ${GROUPBASEEXPIRY} = X"true" -o X${GROUPBASEEXPIRY} = X"yes" -o X${GROUPBASEEXPIRY} = X"on" ]; then
      DOEXPIREOVER=true
      RMFILE=${MOST_LOGS}/expire.rm
      DOGROUPBASEEXPIRY=true
--- 78,84 ----
  DOGROUPBASEEXPIRY=false
  
  GROUPBASEEXPIRY=`echo X${GROUPBASEEXPIRY} | tr ${AZ} ${az}`
! if [ ${GROUPBASEEXPIRY} = x"true" -o ${GROUPBASEEXPIRY} = x"yes" -o ${GROUPBASEEXPIRY} = x"on" ]; then
      DOEXPIREOVER=true
      RMFILE=${MOST_LOGS}/expire.rm
      DOGROUPBASEEXPIRY=true
***************
*** 248,254 ****
  }
  
  # group based expiry (delete expired overview first)
! if [ ${DOGROUPBASEEXPIRY} -a ${DOEXPIREOVER} ] ; then
      if ${DOEXPLOG}; then
  	echo "${EXPIREOVER} start `date`: (${EXPIREOVERFLAGS})" >>${EXPLOG}
      fi
--- 248,254 ----
  }
  
  # group based expiry (delete expired overview first)
! if [ ${DOGROUPBASEEXPIRY} = true -a ${DOEXPIREOVER} = true ] ; then
      if ${DOEXPLOG}; then
  	echo "${EXPIREOVER} start `date`: (${EXPIREOVERFLAGS})" >>${EXPLOG}
      fi
***************
*** 405,411 ****
  rm ${LOCK}
  
  ## Remove the articles that are supposed to go
! if [ ${DOEXPIRE} -a ! ${DOGROUPBASEEXPIRY} ] ; then
      test -n "${RMFILE}" -a -s "${RMFILE}" && {
  	mv ${RMFILE} ${RMFILE}.$$ && RMFILE=${RMFILE}.$$
  
--- 405,411 ----
  rm ${LOCK}
  
  ## Remove the articles that are supposed to go
! if [ ${DOEXPIRE} = true -a ${DOGROUPBASEEXPIRY} != true ] ; then
      test -n "${RMFILE}" -a -s "${RMFILE}" && {
  	mv ${RMFILE} ${RMFILE}.$$ && RMFILE=${RMFILE}.$$
  


More information about the inn-workers mailing list