Outstanding history items

Alex Kiernan alexk at demon.net
Mon Jul 16 12:10:52 UTC 2001


Russ Allbery <rra at stanford.edu> writes:

> Alex Kiernan <alexk at demon.net> writes:
> 
> > I wanted to always build a separate tagged hash implementation, but I'd
> > like it to be usable with large files enabled, unless there's good
> > technical reasons why not (which doesn't really appear to be the case
> > AFAICT).
> 
> My recommendation would be to not store off_t into the hashes for the
> tagged hash implementation.  Instead, store some explicitly sized entity
> like uint32_t or whatever it expects, and always copy off_t into a
> variable of that type when storing.  If off_t > the size limit of that
> variable, check for that case and complain loudly.
> 

It looks a lot like the code already deals with much of that (apart
from the loud complaining should you overflow), there's a separate
type `of_t' which seems to be used everywhere it matters.

I'll have a play with it.

-- 
Alex Kiernan, Principal Engineer, Development, Thus PLC


More information about the inn-workers mailing list