alexk at demon.net
Wed Aug 14 05:27:21 UTC 2002
Russ Allbery <rra at stanford.edu> writes:
> Alex Kiernan <alexk at demon.net> writes:
> > With all the hacking on nnrpd I've been doing, I've become more & more
> > aware of the amount of duplication we have in the manipulation of
> > articles.
> > I've started pulling some of the wire format article manipulation into
> > lib/wire.c (but right now all there is a wire_findbody)
> > Good idea/bad idea?
> >  the only reason I implemented this one was it stuck out at the top
> > of a profiling session as the number one user of CPU cycles
> Sounds like a good idea to me. The more stuff that we pull out into lib
> the better.
OK, I'll commit it later today.
> BTW, while we're on that topic, would you mind if I pulled syspagesize out
> of lib/mmap.c and instead just wrote a replacement for getpagesize for
> systems that don't have it and then modified INN to just use getpagesize
> everywhere? It looks like there are uses in the storage handlers that
> this would simplify as well.
Please feel free! I started adding it as it was another of those where
we had the same code scattered everywhere.
Alex Kiernan, Principal Engineer, Development, THUS plc
More information about the inn-workers