INN::Config Perl module
Russ Allbery
rra at stanford.edu
Mon Sep 17 02:06:03 UTC 2007
Julien ÉLIE <julien at trigofacile.com> writes:
> I have finished and it seems to work pretty well.
> The remaining issues are:
> * In samples/nnrpd_access_wrapper.pl.in, I have a warning:
> Name "main::attributes" used only once: possible typo at samples/nnrpd_access_wrapper.pl.in line 30.
> It is:
> sub access {
> # Comment this out if you don't need auth_init.
> old_auth_init();
> $attributes{type} = "connect";
> [...]
> I do not know what to do with that. How is it possible
> to prevent that warning?
Declare %attributes with a:
use vars qw(%attributes);
at the top of that script. It's a global variable in the nnrpd Perl API.
> * As for scripts/inncheck.in, why is it processed by configure?
> Couldn't it be dropped from configure and generated like the
> major part of the scripts?
> It calls a lot $inn::... so, unlike innupgrade (which is to
> be run without innconfval), I do not understand why inncheck
> is transformed at configure time. Maybe I am missing something.
Search for the pattern '@[A-Z_]*@' to see why a given file is processed by
configure. As I recall, it cares about some file modes that were never
part of the innshellvars.pl interface (but could be, and probably should
be).
> * scripts/simpleftp.in does not currently use innshellvars.pl
> even though it declares it. Should that behaviour be kept?
> I believe it will be the only script without "perl -w" now :)
> It is very great!
It doesn't look like it needs innshellvars.pl, so I'd just remove the
reference. (It should probably be converted to use Net::FTP at some
point, although it uses ftp.pl because it's actually backward compatible
all the way to Perl 4.)
--
Russ Allbery (rra at stanford.edu) <http://www.eyrie.org/~eagle/>
Please send questions to the list rather than mailing me directly.
<http://www.eyrie.org/~eagle/faqs/questions.html> explains why.
More information about the inn-workers
mailing list