Call for inncheck testing

Julien ÉLIE julien at trigofacile.com
Sat Jul 9 19:18:26 UTC 2011


Hi Russ,

>> However, when innfeed is built with mmap support, the default value is
>> "true".  What should we do?  Fix the documentation and say that it is
>> set to "true" by default; or change the default value to "false" in the
>> source code?
>
> The value of this parameter is only used when innfeed is given file names
> to send instead of storage API tokens, which is a fairly rare use case, so
> it's a mostly unimportant setting at this point.  If one is feeding
> innfeed file names, my guess is that it's somewhat more likely that
> they'll be in native format than in wire format, so I'd be inclined to
> change the default in the code to false.  For the normal case of innfeed
> used via newsfeeds, this won't change anything.

All right.  Thanks for the clarification.  Let's use false as the 
default in the source code.

-- 
Julien ÉLIE

« Pour Rome, la direction importe peu, car tous les chemins y
   mènent. » (Astérix)



More information about the inn-workers mailing list