INN 2.6.4 util/inndf test 6 gives different result on ppc64le on Fedora

Dominik 'Rathann' Mierzejewski dominik at greysector.net
Tue Feb 16 22:06:42 UTC 2021


Hi, Julien!

On Tuesday, 16 February 2021 at 22:16, Julien ÉLIE wrote:
> Hi Dominik,
> 
> > That works without making the patch conditional on ppc64le arch, thanks!
> 
> As for the INN 2.6.4 Fedora package, I think you can drop
> inn-2.6.4-pie.patch because it is now enforced by default for the whole
> build.  I've checked in the Fedora build logs, that it is OK:
> 
> checking if gcc supports -fPIE... yes
> checking if gcc supports -pie for linking... yes
> 
> Every program built has that flag, and both rnews and innd have it twice :)

I'll drop it.

> Description of the inn package needs being reviewed:
[...]

The description was written by previous maintainers. I'll update it
according to your suggestions.

> inn-devel package:
> I've looked at the installed files.  These two ones for INN Perl modules
> should not be in inn-devel but in inn directly:
>   /usr/share/man/man3/INN::Config.3pm.gz
>   /usr/share/man/man3/INN::Utils::Shlock.3pm.gz

I'll move them, thanks.

> Also, maybe clibrary.h and config.h should not be in inn-devel but in inn.

I'll move those as well.

> inn package:
> A few files ending with ".in" are mentioned in /usr/share/doc/inn/samples as
> installed files; they should be excluded.

Will do.

Thanks for the thorough review!

Regards,
Dominik

-- 
Fedora   https://getfedora.org  |  RPM Fusion  http://rpmfusion.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
        -- from "Collected Sayings of Muad'Dib" by the Princess Irulan


More information about the inn-workers mailing list